"""Tests for tools/send_message_tool.py.""" import asyncio import json import os import sys from pathlib import Path from types import SimpleNamespace from unittest.mock import AsyncMock, MagicMock, patch from gateway.config import Platform from tools.send_message_tool import ( _parse_target_ref, _send_discord, _send_matrix_via_adapter, _send_telegram, _send_to_platform, send_message_tool, ) def _run_async_immediately(coro): return asyncio.run(coro) def _make_config(): telegram_cfg = SimpleNamespace(enabled=True, token="***", extra={}) return SimpleNamespace( platforms={Platform.TELEGRAM: telegram_cfg}, get_home_channel=lambda _platform: None, ), telegram_cfg def _install_telegram_mock(monkeypatch, bot): parse_mode = SimpleNamespace(MARKDOWN_V2="MarkdownV2", HTML="HTML") constants_mod = SimpleNamespace(ParseMode=parse_mode) telegram_mod = SimpleNamespace(Bot=lambda token: bot, constants=constants_mod) monkeypatch.setitem(sys.modules, "telegram", telegram_mod) monkeypatch.setitem(sys.modules, "telegram.constants", constants_mod) def _ensure_slack_mock(monkeypatch): if "slack_bolt" in sys.modules and hasattr(sys.modules["slack_bolt"], "__file__"): return slack_bolt = MagicMock() slack_bolt.async_app.AsyncApp = MagicMock slack_bolt.adapter.socket_mode.async_handler.AsyncSocketModeHandler = MagicMock slack_sdk = MagicMock() slack_sdk.web.async_client.AsyncWebClient = MagicMock for name, mod in [ ("slack_bolt", slack_bolt), ("slack_bolt.async_app", slack_bolt.async_app), ("slack_bolt.adapter", slack_bolt.adapter), ("slack_bolt.adapter.socket_mode", slack_bolt.adapter.socket_mode), ("slack_bolt.adapter.socket_mode.async_handler", slack_bolt.adapter.socket_mode.async_handler), ("slack_sdk", slack_sdk), ("slack_sdk.web", slack_sdk.web), ("slack_sdk.web.async_client", slack_sdk.web.async_client), ]: monkeypatch.setitem(sys.modules, name, mod) class TestSendMessageTool: def test_cron_duplicate_target_is_skipped_and_explained(self): home = SimpleNamespace(chat_id="-1001") config, _telegram_cfg = _make_config() config.get_home_channel = lambda _platform: home with patch.dict( os.environ, { "HERMES_CRON_AUTO_DELIVER_PLATFORM": "telegram", "HERMES_CRON_AUTO_DELIVER_CHAT_ID": "-1001", }, clear=False, ), \ patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True) as mirror_mock: result = json.loads( send_message_tool( { "action": "send", "target": "telegram", "message": "hello", } ) ) assert result["success"] is True assert result["skipped"] is True assert result["reason"] == "cron_auto_delivery_duplicate_target" assert "final response" in result["note"] send_mock.assert_not_awaited() mirror_mock.assert_not_called() def test_cron_different_target_still_sends(self): config, telegram_cfg = _make_config() with patch.dict( os.environ, { "HERMES_CRON_AUTO_DELIVER_PLATFORM": "telegram", "HERMES_CRON_AUTO_DELIVER_CHAT_ID": "-1001", }, clear=False, ), \ patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True) as mirror_mock: result = json.loads( send_message_tool( { "action": "send", "target": "telegram:-1002", "message": "hello", } ) ) assert result["success"] is True assert result.get("skipped") is not True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1002", "hello", thread_id=None, media_files=[], ) mirror_mock.assert_called_once_with("telegram", "-1002", "hello", source_label="cli", thread_id=None) def test_cron_same_chat_different_thread_still_sends(self): config, telegram_cfg = _make_config() with patch.dict( os.environ, { "HERMES_CRON_AUTO_DELIVER_PLATFORM": "telegram", "HERMES_CRON_AUTO_DELIVER_CHAT_ID": "-1001", "HERMES_CRON_AUTO_DELIVER_THREAD_ID": "17585", }, clear=False, ), \ patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True) as mirror_mock: result = json.loads( send_message_tool( { "action": "send", "target": "telegram:-1001:99999", "message": "hello", } ) ) assert result["success"] is True assert result.get("skipped") is not True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1001", "hello", thread_id="99999", media_files=[], ) mirror_mock.assert_called_once_with("telegram", "-1001", "hello", source_label="cli", thread_id="99999") def test_sends_to_explicit_telegram_topic_target(self): config, telegram_cfg = _make_config() with patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True) as mirror_mock: result = json.loads( send_message_tool( { "action": "send", "target": "telegram:-1001:17585", "message": "hello", } ) ) assert result["success"] is True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1001", "hello", thread_id="17585", media_files=[], ) mirror_mock.assert_called_once_with("telegram", "-1001", "hello", source_label="cli", thread_id="17585") def test_resolved_telegram_topic_name_preserves_thread_id(self): config, telegram_cfg = _make_config() with patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("gateway.channel_directory.resolve_channel_name", return_value="-1001:17585"), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True): result = json.loads( send_message_tool( { "action": "send", "target": "telegram:Coaching Chat / topic 17585", "message": "hello", } ) ) assert result["success"] is True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1001", "hello", thread_id="17585", media_files=[], ) def test_display_label_target_resolves_via_channel_directory(self, tmp_path): config, telegram_cfg = _make_config() cache_file = tmp_path / "channel_directory.json" cache_file.write_text(json.dumps({ "updated_at": "2026-01-01T00:00:00", "platforms": { "telegram": [ {"id": "-1001:17585", "name": "Coaching Chat / topic 17585", "type": "group"} ] }, })) with patch("gateway.channel_directory.DIRECTORY_PATH", cache_file), \ patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True): result = json.loads( send_message_tool( { "action": "send", "target": "telegram:Coaching Chat / topic 17585 (group)", "message": "hello", } ) ) assert result["success"] is True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1001", "hello", thread_id="17585", media_files=[], ) def test_media_only_message_uses_placeholder_for_mirroring(self): config, telegram_cfg = _make_config() with patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_run_async_immediately), \ patch("tools.send_message_tool._send_to_platform", new=AsyncMock(return_value={"success": True})) as send_mock, \ patch("gateway.mirror.mirror_to_session", return_value=True) as mirror_mock: result = json.loads( send_message_tool( { "action": "send", "target": "telegram:-1001", "message": "MEDIA:/tmp/example.ogg", } ) ) assert result["success"] is True send_mock.assert_awaited_once_with( Platform.TELEGRAM, telegram_cfg, "-1001", "", thread_id=None, media_files=[("/tmp/example.ogg", False)], ) mirror_mock.assert_called_once_with( "telegram", "-1001", "[Sent audio attachment]", source_label="cli", thread_id=None, ) def test_top_level_send_failure_redacts_query_token(self): config, _telegram_cfg = _make_config() leaked = "very-secret-query-token-123456" def _raise_and_close(coro): coro.close() raise RuntimeError( f"transport error: https://api.example.com/send?access_token={leaked}" ) with patch("gateway.config.load_gateway_config", return_value=config), \ patch("tools.interrupt.is_interrupted", return_value=False), \ patch("model_tools._run_async", side_effect=_raise_and_close): result = json.loads( send_message_tool( { "action": "send", "target": "telegram:-1001", "message": "hello", } ) ) assert "error" in result assert leaked not in result["error"] assert "access_token=***" in result["error"] class TestSendTelegramMediaDelivery: def test_sends_text_then_photo_for_media_tag(self, tmp_path, monkeypatch): image_path = tmp_path / "photo.png" image_path.write_bytes(b"\x89PNG\r\n\x1a\n" + b"\x00" * 32) bot = MagicMock() bot.send_message = AsyncMock(return_value=SimpleNamespace(message_id=1)) bot.send_photo = AsyncMock(return_value=SimpleNamespace(message_id=2)) bot.send_video = AsyncMock() bot.send_voice = AsyncMock() bot.send_audio = AsyncMock() bot.send_document = AsyncMock() _install_telegram_mock(monkeypatch, bot) result = asyncio.run( _send_telegram( "token", "12345", "Hello there", media_files=[(str(image_path), False)], ) ) assert result["success"] is True assert result["message_id"] == "2" bot.send_message.assert_awaited_once() bot.send_photo.assert_awaited_once() sent_text = bot.send_message.await_args.kwargs["text"] assert "MEDIA:" not in sent_text assert sent_text == "Hello there" def test_sends_voice_for_ogg_with_voice_directive(self, tmp_path, monkeypatch): voice_path = tmp_path / "voice.ogg" voice_path.write_bytes(b"OggS" + b"\x00" * 32) bot = MagicMock() bot.send_message = AsyncMock() bot.send_photo = AsyncMock() bot.send_video = AsyncMock() bot.send_voice = AsyncMock(return_value=SimpleNamespace(message_id=7)) bot.send_audio = AsyncMock() bot.send_document = AsyncMock() _install_telegram_mock(monkeypatch, bot) result = asyncio.run( _send_telegram( "token", "12345", "", media_files=[(str(voice_path), True)], ) ) assert result["success"] is True bot.send_voice.assert_awaited_once() bot.send_audio.assert_not_awaited() bot.send_message.assert_not_awaited() def test_sends_audio_for_mp3(self, tmp_path, monkeypatch): audio_path = tmp_path / "clip.mp3" audio_path.write_bytes(b"ID3" + b"\x00" * 32) bot = MagicMock() bot.send_message = AsyncMock() bot.send_photo = AsyncMock() bot.send_video = AsyncMock() bot.send_voice = AsyncMock() bot.send_audio = AsyncMock(return_value=SimpleNamespace(message_id=8)) bot.send_document = AsyncMock() _install_telegram_mock(monkeypatch, bot) result = asyncio.run( _send_telegram( "token", "12345", "", media_files=[(str(audio_path), False)], ) ) assert result["success"] is True bot.send_audio.assert_awaited_once() bot.send_voice.assert_not_awaited() def test_missing_media_returns_error_without_leaking_raw_tag(self, monkeypatch): bot = MagicMock() bot.send_message = AsyncMock() bot.send_photo = AsyncMock() bot.send_video = AsyncMock() bot.send_voice = AsyncMock() bot.send_audio = AsyncMock() bot.send_document = AsyncMock() _install_telegram_mock(monkeypatch, bot) result = asyncio.run( _send_telegram( "token", "12345", "", media_files=[("/tmp/does-not-exist.png", False)], ) ) assert "error" in result assert "No deliverable text or media remained" in result["error"] bot.send_message.assert_not_awaited() # --------------------------------------------------------------------------- # Regression: long messages are chunked before platform dispatch # --------------------------------------------------------------------------- class TestSendToPlatformChunking: def test_long_message_is_chunked(self): """Messages exceeding the platform limit are split into multiple sends.""" send = AsyncMock(return_value={"success": True, "message_id": "1"}) long_msg = "word " * 1000 # ~5000 chars, well over Discord's 2000 limit with patch("tools.send_message_tool._send_discord", send): result = asyncio.run( _send_to_platform( Platform.DISCORD, SimpleNamespace(enabled=True, token="***", extra={}), "ch", long_msg, ) ) assert result["success"] is True assert send.await_count >= 3 for call in send.await_args_list: assert len(call.args[2]) <= 2020 # each chunk fits the limit def test_slack_messages_are_formatted_before_send(self, monkeypatch): _ensure_slack_mock(monkeypatch) import gateway.platforms.slack as slack_mod monkeypatch.setattr(slack_mod, "SLACK_AVAILABLE", True) send = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_slack", send): result = asyncio.run( _send_to_platform( Platform.SLACK, SimpleNamespace(enabled=True, token="***", extra={}), "C123", "**hello** from [Hermes]()", ) ) assert result["success"] is True send.assert_awaited_once_with( "***", "C123", "*hello* from ", ) def test_slack_bold_italic_formatted_before_send(self, monkeypatch): """Bold+italic ***text*** survives tool-layer formatting.""" _ensure_slack_mock(monkeypatch) import gateway.platforms.slack as slack_mod monkeypatch.setattr(slack_mod, "SLACK_AVAILABLE", True) send = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_slack", send): result = asyncio.run( _send_to_platform( Platform.SLACK, SimpleNamespace(enabled=True, token="***", extra={}), "C123", "***important*** update", ) ) assert result["success"] is True sent_text = send.await_args.args[2] assert "*_important_*" in sent_text def test_slack_blockquote_formatted_before_send(self, monkeypatch): """Blockquote '>' markers must survive formatting (not escaped to '>').""" _ensure_slack_mock(monkeypatch) import gateway.platforms.slack as slack_mod monkeypatch.setattr(slack_mod, "SLACK_AVAILABLE", True) send = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_slack", send): result = asyncio.run( _send_to_platform( Platform.SLACK, SimpleNamespace(enabled=True, token="***", extra={}), "C123", "> important quote\n\nnormal text & stuff", ) ) assert result["success"] is True sent_text = send.await_args.args[2] assert sent_text.startswith("> important quote") assert "&" in sent_text # & is escaped assert ">" not in sent_text.split("\n")[0] # > in blockquote is NOT escaped def test_slack_pre_escaped_entities_not_double_escaped(self, monkeypatch): """Pre-escaped HTML entities survive tool-layer formatting without double-escaping.""" _ensure_slack_mock(monkeypatch) import gateway.platforms.slack as slack_mod monkeypatch.setattr(slack_mod, "SLACK_AVAILABLE", True) send = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_slack", send): result = asyncio.run( _send_to_platform( Platform.SLACK, SimpleNamespace(enabled=True, token="***", extra={}), "C123", "AT&T <tag> test", ) ) assert result["success"] is True sent_text = send.await_args.args[2] assert "&amp;" not in sent_text assert "&lt;" not in sent_text assert "AT&T" in sent_text def test_slack_url_with_parens_formatted_before_send(self, monkeypatch): """Wikipedia-style URL with parens survives tool-layer formatting.""" _ensure_slack_mock(monkeypatch) import gateway.platforms.slack as slack_mod monkeypatch.setattr(slack_mod, "SLACK_AVAILABLE", True) send = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_slack", send): result = asyncio.run( _send_to_platform( Platform.SLACK, SimpleNamespace(enabled=True, token="***", extra={}), "C123", "See [Foo](https://en.wikipedia.org/wiki/Foo_(bar))", ) ) assert result["success"] is True sent_text = send.await_args.args[2] assert "" in sent_text def test_telegram_media_attaches_to_last_chunk(self): sent_calls = [] async def fake_send(token, chat_id, message, media_files=None, thread_id=None, disable_link_previews=False): sent_calls.append(media_files or []) return {"success": True, "platform": "telegram", "chat_id": chat_id, "message_id": str(len(sent_calls))} long_msg = "word " * 2000 # ~10000 chars, well over 4096 media = [("/tmp/photo.png", False)] with patch("tools.send_message_tool._send_telegram", fake_send): asyncio.run( _send_to_platform( Platform.TELEGRAM, SimpleNamespace(enabled=True, token="tok", extra={}), "123", long_msg, media_files=media, ) ) assert len(sent_calls) >= 3 assert all(call == [] for call in sent_calls[:-1]) assert sent_calls[-1] == media def test_matrix_media_uses_native_adapter_helper(self): doc_path = Path("/tmp/test-send-message-matrix.pdf") doc_path.write_bytes(b"%PDF-1.4 test") try: helper = AsyncMock(return_value={"success": True, "platform": "matrix", "chat_id": "!room:example.com", "message_id": "$evt"}) with patch("tools.send_message_tool._send_matrix_via_adapter", helper): result = asyncio.run( _send_to_platform( Platform.MATRIX, SimpleNamespace(enabled=True, token="tok", extra={"homeserver": "https://matrix.example.com"}), "!room:example.com", "here you go", media_files=[(str(doc_path), False)], ) ) assert result["success"] is True helper.assert_awaited_once() call = helper.await_args assert call.args[1] == "!room:example.com" assert call.args[2] == "here you go" assert call.kwargs["media_files"] == [(str(doc_path), False)] finally: doc_path.unlink(missing_ok=True) def test_matrix_text_only_uses_lightweight_path(self): """Text-only Matrix sends should NOT go through the heavy adapter path.""" helper = AsyncMock() lightweight = AsyncMock(return_value={"success": True, "platform": "matrix", "chat_id": "!room:ex.com", "message_id": "$txt"}) with patch("tools.send_message_tool._send_matrix_via_adapter", helper), \ patch("tools.send_message_tool._send_matrix", lightweight): result = asyncio.run( _send_to_platform( Platform.MATRIX, SimpleNamespace(enabled=True, token="tok", extra={"homeserver": "https://matrix.example.com"}), "!room:ex.com", "just text, no files", ) ) assert result["success"] is True helper.assert_not_awaited() lightweight.assert_awaited_once() def test_send_matrix_via_adapter_sends_document(self, tmp_path): file_path = tmp_path / "report.pdf" file_path.write_bytes(b"%PDF-1.4 test") calls = [] class FakeAdapter: def __init__(self, _config): self.connected = False async def connect(self): self.connected = True calls.append(("connect",)) return True async def send(self, chat_id, message, metadata=None): calls.append(("send", chat_id, message, metadata)) return SimpleNamespace(success=True, message_id="$text") async def send_document(self, chat_id, file_path, metadata=None): calls.append(("send_document", chat_id, file_path, metadata)) return SimpleNamespace(success=True, message_id="$file") async def disconnect(self): calls.append(("disconnect",)) fake_module = SimpleNamespace(MatrixAdapter=FakeAdapter) with patch.dict(sys.modules, {"gateway.platforms.matrix": fake_module}): result = asyncio.run( _send_matrix_via_adapter( SimpleNamespace(enabled=True, token="tok", extra={"homeserver": "https://matrix.example.com"}), "!room:example.com", "report attached", media_files=[(str(file_path), False)], ) ) assert result == { "success": True, "platform": "matrix", "chat_id": "!room:example.com", "message_id": "$file", } assert calls == [ ("connect",), ("send", "!room:example.com", "report attached", None), ("send_document", "!room:example.com", str(file_path), None), ("disconnect",), ] # --------------------------------------------------------------------------- # HTML auto-detection in Telegram send # --------------------------------------------------------------------------- class TestSendToPlatformWhatsapp: def test_whatsapp_routes_via_local_bridge_sender(self): chat_id = "test-user@lid" async_mock = AsyncMock(return_value={"success": True, "platform": "whatsapp", "chat_id": chat_id, "message_id": "abc123"}) with patch("tools.send_message_tool._send_whatsapp", async_mock): result = asyncio.run( _send_to_platform( Platform.WHATSAPP, SimpleNamespace(enabled=True, token=None, extra={"bridge_port": 3000}), chat_id, "hello from hermes", ) ) assert result["success"] is True async_mock.assert_awaited_once_with({"bridge_port": 3000}, chat_id, "hello from hermes") class TestSendTelegramHtmlDetection: """Verify that messages containing HTML tags are sent with parse_mode=HTML and that plain / markdown messages use MarkdownV2.""" def _make_bot(self): bot = MagicMock() bot.send_message = AsyncMock(return_value=SimpleNamespace(message_id=1)) bot.send_photo = AsyncMock() bot.send_video = AsyncMock() bot.send_voice = AsyncMock() bot.send_audio = AsyncMock() bot.send_document = AsyncMock() return bot def test_html_message_uses_html_parse_mode(self, monkeypatch): bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) asyncio.run( _send_telegram("tok", "123", "Hello world") ) bot.send_message.assert_awaited_once() kwargs = bot.send_message.await_args.kwargs assert kwargs["parse_mode"] == "HTML" assert kwargs["text"] == "Hello world" def test_plain_text_uses_markdown_v2(self, monkeypatch): bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) asyncio.run( _send_telegram("tok", "123", "Just plain text, no tags") ) bot.send_message.assert_awaited_once() kwargs = bot.send_message.await_args.kwargs assert kwargs["parse_mode"] == "MarkdownV2" def test_disable_link_previews_sets_disable_web_page_preview(self, monkeypatch): bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) asyncio.run( _send_telegram("tok", "123", "https://example.com", disable_link_previews=True) ) kwargs = bot.send_message.await_args.kwargs assert kwargs["disable_web_page_preview"] is True def test_html_with_code_and_pre_tags(self, monkeypatch): bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) html = "
code block
and inline" asyncio.run(_send_telegram("tok", "123", html)) kwargs = bot.send_message.await_args.kwargs assert kwargs["parse_mode"] == "HTML" def test_closing_tag_detected(self, monkeypatch): bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) asyncio.run(_send_telegram("tok", "123", "text more")) kwargs = bot.send_message.await_args.kwargs assert kwargs["parse_mode"] == "HTML" def test_angle_brackets_in_math_not_detected(self, monkeypatch): """Expressions like 'x < 5' or '3 > 2' should not trigger HTML mode.""" bot = self._make_bot() _install_telegram_mock(monkeypatch, bot) asyncio.run(_send_telegram("tok", "123", "if x < 5 then y > 2")) kwargs = bot.send_message.await_args.kwargs assert kwargs["parse_mode"] == "MarkdownV2" def test_html_parse_failure_falls_back_to_plain(self, monkeypatch): """If Telegram rejects the HTML, fall back to plain text.""" bot = self._make_bot() bot.send_message = AsyncMock( side_effect=[ Exception("Bad Request: can't parse entities: unsupported html tag"), SimpleNamespace(message_id=2), # plain fallback succeeds ] ) _install_telegram_mock(monkeypatch, bot) result = asyncio.run( _send_telegram("tok", "123", "broken html") ) assert result["success"] is True assert bot.send_message.await_count == 2 second_call = bot.send_message.await_args_list[1].kwargs assert second_call["parse_mode"] is None def test_transient_bad_gateway_retries_text_send(self, monkeypatch): bot = self._make_bot() bot.send_message = AsyncMock( side_effect=[ Exception("502 Bad Gateway"), SimpleNamespace(message_id=2), ] ) _install_telegram_mock(monkeypatch, bot) with patch("asyncio.sleep", new=AsyncMock()) as sleep_mock: result = asyncio.run(_send_telegram("tok", "123", "hello")) assert result["success"] is True assert bot.send_message.await_count == 2 sleep_mock.assert_awaited_once() # --------------------------------------------------------------------------- # Tests for Discord thread_id support # --------------------------------------------------------------------------- class TestParseTargetRefDiscord: """_parse_target_ref correctly extracts chat_id and thread_id for Discord.""" def test_discord_chat_id_with_thread_id(self): """discord:chat_id:thread_id returns both values.""" chat_id, thread_id, is_explicit = _parse_target_ref("discord", "-1001234567890:17585") assert chat_id == "-1001234567890" assert thread_id == "17585" assert is_explicit is True def test_discord_chat_id_without_thread_id(self): """discord:chat_id returns None for thread_id.""" chat_id, thread_id, is_explicit = _parse_target_ref("discord", "9876543210") assert chat_id == "9876543210" assert thread_id is None assert is_explicit is True def test_discord_large_snowflake_without_thread(self): """Large Discord snowflake IDs work without thread.""" chat_id, thread_id, is_explicit = _parse_target_ref("discord", "1003724596514") assert chat_id == "1003724596514" assert thread_id is None assert is_explicit is True def test_discord_channel_with_thread(self): """Full Discord format: channel:thread.""" chat_id, thread_id, is_explicit = _parse_target_ref("discord", "1003724596514:99999") assert chat_id == "1003724596514" assert thread_id == "99999" assert is_explicit is True def test_discord_whitespace_is_stripped(self): """Whitespace around Discord targets is stripped.""" chat_id, thread_id, is_explicit = _parse_target_ref("discord", " 123456:789 ") assert chat_id == "123456" assert thread_id == "789" assert is_explicit is True class TestParseTargetRefMatrix: """_parse_target_ref correctly handles Matrix room IDs and user MXIDs.""" def test_matrix_room_id_is_explicit(self): """Matrix room IDs (!) are recognized as explicit targets.""" chat_id, thread_id, is_explicit = _parse_target_ref("matrix", "!HLOQwxYGgFPMPJUSNR:matrix.org") assert chat_id == "!HLOQwxYGgFPMPJUSNR:matrix.org" assert thread_id is None assert is_explicit is True def test_matrix_user_mxid_is_explicit(self): """Matrix user MXIDs (@) are recognized as explicit targets.""" chat_id, thread_id, is_explicit = _parse_target_ref("matrix", "@hermes:matrix.org") assert chat_id == "@hermes:matrix.org" assert thread_id is None assert is_explicit is True def test_matrix_alias_is_not_explicit(self): """Matrix room aliases (#) are NOT explicit — they need resolution.""" chat_id, thread_id, is_explicit = _parse_target_ref("matrix", "#general:matrix.org") assert chat_id is None assert is_explicit is False def test_matrix_prefix_only_matches_matrix_platform(self): """! and @ prefixes are only treated as explicit for the matrix platform.""" chat_id, _, is_explicit = _parse_target_ref("telegram", "!something") assert is_explicit is False chat_id, _, is_explicit = _parse_target_ref("discord", "@someone") assert is_explicit is False class TestSendDiscordThreadId: """_send_discord uses thread_id when provided.""" @staticmethod def _build_mock(response_status, response_data=None, response_text="error body"): """Build a properly-structured aiohttp mock chain. session.post() returns a context manager yielding mock_resp. """ mock_resp = MagicMock() mock_resp.status = response_status mock_resp.json = AsyncMock(return_value=response_data or {"id": "msg123"}) mock_resp.text = AsyncMock(return_value=response_text) # mock_resp as async context manager (for "async with session.post(...) as resp") mock_resp.__aenter__ = AsyncMock(return_value=mock_resp) mock_resp.__aexit__ = AsyncMock(return_value=None) mock_session = MagicMock() mock_session.__aenter__ = AsyncMock(return_value=mock_session) mock_session.__aexit__ = AsyncMock(return_value=None) mock_session.post = MagicMock(return_value=mock_resp) return mock_session, mock_resp def _run(self, token, chat_id, message, thread_id=None): return asyncio.run(_send_discord(token, chat_id, message, thread_id=thread_id)) def test_without_thread_id_uses_chat_id_endpoint(self): """When no thread_id, sends to /channels/{chat_id}/messages.""" mock_session, _ = self._build_mock(200) with patch("aiohttp.ClientSession", return_value=mock_session): self._run("tok", "111222333", "hello world") call_url = mock_session.post.call_args.args[0] assert call_url == "https://discord.com/api/v10/channels/111222333/messages" def test_with_thread_id_uses_thread_endpoint(self): """When thread_id is provided, sends to /channels/{thread_id}/messages.""" mock_session, _ = self._build_mock(200) with patch("aiohttp.ClientSession", return_value=mock_session): self._run("tok", "999888777", "hello from thread", thread_id="555444333") call_url = mock_session.post.call_args.args[0] assert call_url == "https://discord.com/api/v10/channels/555444333/messages" def test_success_returns_message_id(self): """Successful send returns the Discord message ID.""" mock_session, _ = self._build_mock(200, response_data={"id": "9876543210"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = self._run("tok", "111", "hi", thread_id="999") assert result["success"] is True assert result["message_id"] == "9876543210" assert result["chat_id"] == "111" def test_error_status_returns_error_dict(self): """Non-200/201 responses return an error dict.""" mock_session, _ = self._build_mock(403, response_data={"message": "Forbidden"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = self._run("tok", "111", "hi") assert "error" in result assert "403" in result["error"] class TestSendToPlatformDiscordThread: """_send_to_platform passes thread_id through to _send_discord.""" def test_discord_thread_id_passed_to_send_discord(self): """Discord platform with thread_id passes it to _send_discord.""" send_mock = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_discord", send_mock): result = asyncio.run( _send_to_platform( Platform.DISCORD, SimpleNamespace(enabled=True, token="tok", extra={}), "-1001234567890", "hello thread", thread_id="17585", ) ) assert result["success"] is True send_mock.assert_awaited_once() _, call_kwargs = send_mock.await_args assert call_kwargs["thread_id"] == "17585" def test_discord_no_thread_id_when_not_provided(self): """Discord platform without thread_id passes None.""" send_mock = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_discord", send_mock): result = asyncio.run( _send_to_platform( Platform.DISCORD, SimpleNamespace(enabled=True, token="tok", extra={}), "9876543210", "hello channel", ) ) send_mock.assert_awaited_once() _, call_kwargs = send_mock.await_args assert call_kwargs["thread_id"] is None # --------------------------------------------------------------------------- # Discord media attachment support # --------------------------------------------------------------------------- class TestSendDiscordMedia: """_send_discord uploads media files via multipart/form-data.""" @staticmethod def _build_mock(response_status, response_data=None, response_text="error body"): """Build a properly-structured aiohttp mock chain.""" mock_resp = MagicMock() mock_resp.status = response_status mock_resp.json = AsyncMock(return_value=response_data or {"id": "msg123"}) mock_resp.text = AsyncMock(return_value=response_text) mock_resp.__aenter__ = AsyncMock(return_value=mock_resp) mock_resp.__aexit__ = AsyncMock(return_value=None) mock_session = MagicMock() mock_session.__aenter__ = AsyncMock(return_value=mock_session) mock_session.__aexit__ = AsyncMock(return_value=None) mock_session.post = MagicMock(return_value=mock_resp) return mock_session, mock_resp def test_text_and_media_sends_both(self, tmp_path): """Text message is sent first, then each media file as multipart.""" img = tmp_path / "photo.png" img.write_bytes(b"\x89PNG fake image data") mock_session, _ = self._build_mock(200, {"id": "msg999"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "111", "hello", media_files=[(str(img), False)]) ) assert result["success"] is True assert result["message_id"] == "msg999" # Two POSTs: one text JSON, one multipart upload assert mock_session.post.call_count == 2 def test_media_only_skips_text_post(self, tmp_path): """When message is empty and media is present, text POST is skipped.""" img = tmp_path / "photo.png" img.write_bytes(b"\x89PNG fake image data") mock_session, _ = self._build_mock(200, {"id": "media_only"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "222", " ", media_files=[(str(img), False)]) ) assert result["success"] is True # Only one POST: the media upload (text was whitespace-only) assert mock_session.post.call_count == 1 def test_missing_media_file_collected_as_warning(self): """Non-existent media paths produce warnings but don't fail.""" mock_session, _ = self._build_mock(200, {"id": "txt_ok"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "333", "hello", media_files=[("/nonexistent/file.png", False)]) ) assert result["success"] is True assert "warnings" in result assert any("not found" in w for w in result["warnings"]) # Only the text POST was made, media was skipped assert mock_session.post.call_count == 1 def test_media_upload_failure_collected_as_warning(self, tmp_path): """Failed media upload becomes a warning, text still succeeds.""" img = tmp_path / "photo.png" img.write_bytes(b"\x89PNG fake image data") # First call (text) succeeds, second call (media) returns 413 text_resp = MagicMock() text_resp.status = 200 text_resp.json = AsyncMock(return_value={"id": "txt_ok"}) text_resp.__aenter__ = AsyncMock(return_value=text_resp) text_resp.__aexit__ = AsyncMock(return_value=None) media_resp = MagicMock() media_resp.status = 413 media_resp.text = AsyncMock(return_value="Request Entity Too Large") media_resp.__aenter__ = AsyncMock(return_value=media_resp) media_resp.__aexit__ = AsyncMock(return_value=None) mock_session = MagicMock() mock_session.__aenter__ = AsyncMock(return_value=mock_session) mock_session.__aexit__ = AsyncMock(return_value=None) mock_session.post = MagicMock(side_effect=[text_resp, media_resp]) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "444", "hello", media_files=[(str(img), False)]) ) assert result["success"] is True assert result["message_id"] == "txt_ok" assert "warnings" in result assert any("413" in w for w in result["warnings"]) def test_no_text_no_media_returns_error(self): """Empty text with no media returns error dict.""" mock_session, _ = self._build_mock(200) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "555", "", media_files=[]) ) # Text is empty but media_files is empty, so text POST fires # (the "skip text if media present" condition isn't met) assert result["success"] is True def test_multiple_media_files_uploaded_separately(self, tmp_path): """Each media file gets its own multipart POST.""" img1 = tmp_path / "a.png" img1.write_bytes(b"img1") img2 = tmp_path / "b.jpg" img2.write_bytes(b"img2") mock_session, _ = self._build_mock(200, {"id": "last"}) with patch("aiohttp.ClientSession", return_value=mock_session): result = asyncio.run( _send_discord("tok", "666", "hi", media_files=[ (str(img1), False), (str(img2), False) ]) ) assert result["success"] is True # 1 text POST + 2 media POSTs = 3 assert mock_session.post.call_count == 3 class TestSendToPlatformDiscordMedia: """_send_to_platform routes Discord media correctly.""" def test_media_files_passed_on_last_chunk_only(self): """Discord media_files are only passed on the final chunk.""" call_log = [] async def mock_send_discord(token, chat_id, message, thread_id=None, media_files=None): call_log.append({"message": message, "media_files": media_files or []}) return {"success": True, "platform": "discord", "chat_id": chat_id, "message_id": "1"} # A message long enough to get chunked (Discord limit is 2000) long_msg = "A" * 1900 + " " + "B" * 1900 with patch("tools.send_message_tool._send_discord", side_effect=mock_send_discord): result = asyncio.run( _send_to_platform( Platform.DISCORD, SimpleNamespace(enabled=True, token="tok", extra={}), "999", long_msg, media_files=[("/fake/img.png", False)], ) ) assert result["success"] is True assert len(call_log) == 2 # Message was chunked assert call_log[0]["media_files"] == [] # First chunk: no media assert call_log[1]["media_files"] == [("/fake/img.png", False)] # Last chunk: media attached def test_single_chunk_gets_media(self): """Short message (single chunk) gets media_files directly.""" send_mock = AsyncMock(return_value={"success": True, "message_id": "1"}) with patch("tools.send_message_tool._send_discord", send_mock): result = asyncio.run( _send_to_platform( Platform.DISCORD, SimpleNamespace(enabled=True, token="tok", extra={}), "888", "short message", media_files=[("/fake/img.png", False)], ) ) assert result["success"] is True send_mock.assert_awaited_once() call_kwargs = send_mock.await_args.kwargs assert call_kwargs["media_files"] == [("/fake/img.png", False)] class TestSendMatrixUrlEncoding: """_send_matrix URL-encodes Matrix room IDs in the API path.""" def test_room_id_is_percent_encoded_in_url(self): """Matrix room IDs with ! and : are percent-encoded in the PUT URL.""" import aiohttp mock_resp = MagicMock() mock_resp.status = 200 mock_resp.json = AsyncMock(return_value={"event_id": "$evt123"}) mock_resp.__aenter__ = AsyncMock(return_value=mock_resp) mock_resp.__aexit__ = AsyncMock(return_value=None) mock_session = MagicMock() mock_session.put = MagicMock(return_value=mock_resp) mock_session.__aenter__ = AsyncMock(return_value=mock_session) mock_session.__aexit__ = AsyncMock(return_value=None) with patch("aiohttp.ClientSession", return_value=mock_session): from tools.send_message_tool import _send_matrix result = asyncio.get_event_loop().run_until_complete( _send_matrix( "test_token", {"homeserver": "https://matrix.example.org"}, "!HLOQwxYGgFPMPJUSNR:matrix.org", "hello", ) ) assert result["success"] is True # Verify the URL was called with percent-encoded room ID put_url = mock_session.put.call_args[0][0] assert "%21HLOQwxYGgFPMPJUSNR%3Amatrix.org" in put_url assert "!HLOQwxYGgFPMPJUSNR:matrix.org" not in put_url